Skip to content

fix: prevent log resolver panic#282

Merged
davidzhao merged 1 commit intomainfrom
prevent-log-panic
Feb 14, 2025
Merged

fix: prevent log resolver panic#282
davidzhao merged 1 commit intomainfrom
prevent-log-panic

Conversation

@davidzhao
Copy link
Copy Markdown
Member

If the room is closed quickly after connect, we could end up with a nil r.room.

If the room is closed quickly after connect, we could end up with a nil
`r.room`.
@davidzhao davidzhao requested a review from a team as a code owner February 14, 2025 22:05
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.95%. Comparing base (0460b40) to head (6aa3a76).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sip/room.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   65.25%   64.95%   -0.30%     
==========================================
  Files          51       52       +1     
  Lines        6588     7265     +677     
==========================================
+ Hits         4299     4719     +420     
- Misses       1915     2143     +228     
- Partials      374      403      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidzhao
Copy link
Copy Markdown
Member Author

@livekit/media-devs I'm merging this one. it seems like the right fix.

@davidzhao davidzhao merged commit 193106c into main Feb 14, 2025
4 checks passed
@davidzhao davidzhao deleted the prevent-log-panic branch February 14, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants