Open
Conversation
alexlivekit
commented
Mar 25, 2026
Comment on lines
-436
to
-438
| if r.StatusCode == 200 { | ||
| _ = c.sipClient.WriteRequest(sip.NewAckRequest(req, r, nil)) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
AFAICT, we should not be sending ACK for BYEs.
That goes for the others here too...
Contributor
There was a problem hiding this comment.
+1 that we should not ack bye. Created a linear a while back for this https://linear.app/livekit/issue/TEL-391/do-not-ack-to-200-ok-bye
alexlivekit
changed the title
alexlivekit
force-pushed
the
alexmigolin/tel-460-incorrect-handling-of-record-route-in-cloud-sip
branch
from
b93e037 to
92613e3
Compare
alexlivekit
force-pushed
the
alexmigolin/tel-460-incorrect-handling-of-record-route-in-cloud-sip
branch
from
92613e3 to
42aebae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of the tests added in #635