Skip to content

Conversation

@corey-livepeer
Copy link
Contributor

These tests have been failing: https://github.com/livepeer/catalyst/actions/workflows/test.yaml

Run docker://morphy/revive-action:v2
Failures
Warning: avoid meaningless package names
Warning: avoid meaningless package names

Warnings like these should not fail the whole workflow

@corey-livepeer corey-livepeer self-assigned this Nov 25, 2025
@corey-livepeer corey-livepeer added the bug Something isn't working label Nov 25, 2025
@corey-livepeer
Copy link
Contributor Author

corey-livepeer commented Nov 25, 2025

The warnings no longer fail the workflow.

CodeQL errors will be handled in another PR, tracked in INF-398

Perform CodeQL analysis
CodeQL Action major versions v1 and v2 have been deprecated. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2025-01-10-code-scanning-codeql-action-v2-is-now-deprecated/

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.91729%. Comparing base (f234579) to head (cb9060e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main       #1071         +/-   ##
===================================================
+ Coverage   63.92405%   66.91729%   +2.99324%     
===================================================
  Files              2           2                 
  Lines            158         133         -25     
===================================================
- Hits             101          89         -12     
+ Misses            40          27         -13     
  Partials          17          17                 

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d5b9b...cb9060e. Read the comment docs.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@corey-livepeer corey-livepeer merged commit 1f37700 into main Nov 27, 2025
2 of 7 checks passed
@corey-livepeer corey-livepeer deleted the corey/INF-399/fix-catalyst-warnings branch November 27, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant