Skip to content

revert: use non-gpu runner #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pwilczynskiclearcode merged 1 commit into from
Apr 11, 2025
Merged

revert: use non-gpu runner #117

pwilczynskiclearcode merged 1 commit into from
Apr 11, 2025

Conversation

@eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Apr 11, 2025

Reverts #110

@eliteprox
Copy link
Collaborator Author

eliteprox commented Apr 11, 2025

@pwilczynskiclearcode It seems like this change broke the builds somehow, so I opened a pr to revert. Even though it built after merging. It appears to be breaking during miniconda + ffmpeg. See https://github.com/livepeer/comfystream/actions/runs/14396432986/job/40372835477#step:6:4344

@eliteprox eliteprox marked this pull request as ready for review April 11, 2025 06:21
@pwilczynskiclearcode
Copy link

pwilczynskiclearcode commented Apr 11, 2025

@pwilczynskiclearcode It seems like this change broke the builds somehow, so I opened a pr to revert. Even though it built after merging. It appears to be breaking during miniconda + ffmpeg. See https://github.com/livepeer/comfystream/actions/runs/14396432986/job/40372835477#step:6:4344

Thanks. I was about to just test if it's possible to build on non-GPU machines.

@pwilczynskiclearcode pwilczynskiclearcode merged commit 9ab0b0d into main Apr 11, 2025
8 checks passed
@pwilczynskiclearcode pwilczynskiclearcode deleted the revert-110-gpu branch April 11, 2025 09:39
@eliteprox
Copy link
Collaborator Author

eliteprox commented Apr 11, 2025

@pwilczynskiclearcode We might be able to try this again, this appears like it might have been caused by an accidental change in an earlier pr that's been reverted now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjpotter92 hjpotter92 Awaiting requested review from hjpotter92

1 more reviewer

@pwilczynskiclearcode pwilczynskiclearcode pwilczynskiclearcode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliteprox @pwilczynskiclearcode