-
Notifications
You must be signed in to change notification settings - Fork 6
feat(docker): add nodes config build arg for custom workers #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
425fa28 to
049c950
Compare
|
Changes need testing as built docker container running as a server. Model downloads and engine builds should go to the paths expected by the example ComfyUI workflow. Example workflow to be added |
|
|
||
| PixelArtRedmond15V-PixelArt-PIXARFK.safetensors: | ||
| name: "PixelArtRedmond15V-PixelArt-PIXARFK" | ||
| url: "https://huggingface.co/artificialguybr/pixelartredmond-1-5v-pixel-art-loras-for-sd-1-5/resolve/ab43d9e2cf8c9240189f01e9cdc4ca341362500c/PixelArtRedmond15V-PixelArt-PIXARFK.safetensors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Models download uses PixelArtRedmond15V-PixelArt-PIXARFK.safetensors, but example workflow uses PixelArt.safetensors
|
Engine builds are needed in |
|
@RUFFY-369 We might need to find a way to link nodes and model/engine configs since. |
…d comment out image name
… and FasterLivePortrait engine builds
| // Commented out to use the build context instead | ||
| // TODO: Update this to the correct image name | ||
| // when using images other than livepeer/comfystream:latest | ||
| // "image": "livepeer/comfystream:streamdiffusion", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated with comments here to allow for quick editing to test images other than livepeer/comfyui-base:latest
This was needed because devcontainer build failed with livepeer/comfyui-base:streamdiffusion as the BASE_IMAGE name.
RUFFY-369
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a NODES_CONFIG build arg to Dockerfile.base to enable ComfyStream BYOC worker builds targeting different sets of custom nodes. A new
--configflag was added tosetup_nodes.pyandsetup_models.pyto configure the environmentThe feature is used to implement ComfyUI-StreamDiffusion using
configs/nodes-streamdiffusion.yamlBuild with custom config from configs directory
base image
comfystream image