Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3275 +/- ##
===================================================
- Coverage 32.16679% 30.41730% -1.74949%
===================================================
Files 147 148 +1
Lines 41033 43518 +2485
===================================================
+ Hits 13199 13237 +38
- Misses 27058 29505 +2447
Partials 776 776
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
rickstaa
force-pushed
the
add_proposal_vote_cli_arg
branch
from
98fa9ab to
8dc634f
Compare
victorges
approved these changes
Jan 6, 2025
| confirm = w.readStringYesOrNo() | ||
| } | ||
|
|
||
| fmt.Printf("Do you want to provide a reason for your vote? (y/n) -") |
Contributor
There was a problem hiding this comment.
Would be awesome to display these in the dashboard at some point!
Contributor
There was a problem hiding this comment.
Mike will be adding it to his vote tracker. At the moment it is just me and Titan setting the reason, but with this PR we might see a lot more Orchestrators add a reason to their vote.
rickstaa
force-pushed
the
add_proposal_vote_cli_arg
branch
from
86714fa to
ad52dce
Compare
leszko
approved these changes
Mar 6, 2025
Contributor
|
LGTM @rickstaa feel free to merge. |
Member
Author
@leszko thanks. I now also tested the code without a reason.
|
rickstaa
requested review from
stronk-dev and
thomshutt
and removed request for
stronk-dev and
thomshutt
This commit allows orchestrators to vote on active treasury proposal directly from the go-livepeer CLI.
This commit ensures that the contract bindings are up to date with the latest version of the livepeer/protocol repository.
This commit renames the internal reference to the LivepeerGovernor contract and improves the proposalVote handler data type parsing behavoir.
This commit makes the CLI description for proposal voting more specific to prevent confusion. Co-authored-by: Victor Elias <victor@livepeer.org>
rickstaa
force-pushed
the
add_proposal_vote_cli_arg
branch
from
4a0fffc to
6caa873
Compare
This was referenced Sep 11, 2025
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This pull request gives orchestrators the ability to vote on active treasury proposal directly from the go-livepeer CLI.
Specific updates (required)
voteOnProposalhandler on the server.go generate client.go. Can you check if these really need to be updated or that my setup is incorrect.How did you test each of these updates (required)
I wrote tests and tested the command line argument with a non-orchestrator wallet since we currently don't have a testnet. @victorges, @leszko if you reviewed this I can test with my actual wallet.
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass