Restart warm container when it does not exist

[leszko]

In case of the warm container, go-livepeer should monitor if the container is running and recreate it if it's stopped.

The issue happened during our deployments, when we update runner image, we need to stop it and then go-livepeer should start it again.

[mjh1]

Just wondering if there are some edge cases where watchContainer exits but we're in a state where createContainer will fail, I guess we keep an eye out for the error log. Does createContainer handle the case where the container is in a stopped state and all it needs to do is start it rather than creating a new one?

[leszko]

Just wondering if there are some edge cases where watchContainer exits but we're in a state where createContainer will fail, I guess we keep an eye out for the error log. Does createContainer handle the case where the container is in a stopped state and all it needs to do is start it rather than creating a new one?

We actually never "stop" container, because it's always started with the -rm flag. So stopping actually means deleting the container.

[codecov]

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.16082%. Comparing base (1c1c280) to head (b0cfb06).

Files with missing lines	Patch %	Lines
ai/worker/docker.go	47.05882%	9 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##              master       #3390         +/-   ##
===================================================
+ Coverage   32.15960%   32.16082%   +0.00122%     
===================================================
  Files            147         147                 
  Lines          40753       40767         +14     
===================================================
+ Hits           13106       13111          +5     
- Misses         26874       26883          +9     
  Partials         773         773                 

Files with missing lines	Coverage Δ
ai/worker/docker.go	73.33333% <47.05882%> (-1.25099%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1c280...b0cfb06. Read the comment docs.

Files with missing lines	Coverage Δ
ai/worker/docker.go	73.33333% <47.05882%> (-1.25099%)	⬇️

[leszko]

Ahh, just realized it may not be that simple as this implementation. I'll need to work a little bit more on that part.

[leszko]

Closing for now