Skip to content

ai/live: remove analyzeduration from rtmp pull.#3422

Merged
j0sh merged 3 commits intomasterfrom
ja/remove-analyzeduration
Feb 26, 2025
Merged

ai/live: remove analyzeduration from rtmp pull.#3422
j0sh merged 3 commits intomasterfrom
ja/remove-analyzeduration

Conversation

@j0sh
Copy link
Copy Markdown
Collaborator

@j0sh j0sh commented Feb 26, 2025

This increases the likelihood we receive enough data to initialize a video track within the alloted time.

The default is 5 seconds so this change would increase average stream startup time by 2.5 seconds.

This increases the likelihood we receive enough data to
initialize a video track within the alloted time.

The default is 5 seconds so this change would increase
average stream startup time by 2.5 seconds.
@j0sh j0sh requested review from emranemran, leszko and mjh1 February 26, 2025 00:12
@github-actions github-actions bot added the go Pull requests that update Go code label Feb 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.13344%. Comparing base (b9cf0ea) to head (522afe0).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3422         +/-   ##
===================================================
+ Coverage   32.13022%   32.13344%   +0.00322%     
===================================================
  Files            147         147                 
  Lines          40977       40976          -1     
===================================================
+ Hits           13166       13167          +1     
+ Misses         27035       27033          -2     
  Partials         776         776                 
Files with missing lines Coverage Δ
media/rtmp2segment.go 3.40426% <ø> (+0.01443%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9cf0ea...522afe0. Read the comment docs.

Files with missing lines Coverage Δ
media/rtmp2segment.go 3.40426% <ø> (+0.01443%) ⬆️

... and 1 file with indirect coverage changes

@emranemran
Copy link
Copy Markdown
Contributor

To confirm, you have seen cases where the video track is not initialized with -analyzeduration of 2.5s? Before we push this to prod, we should confirm what startup time are like on staging.

@j0sh
Copy link
Copy Markdown
Collaborator Author

j0sh commented Feb 26, 2025

To confirm, you have seen cases where the video track is not initialized with -analyzeduration of 2.5s? Before we push this to prod, we should confirm what startup time are like on staging.

@emranemran - the output here is audio only

image

@j0sh j0sh enabled auto-merge (squash) February 26, 2025 17:49
@j0sh j0sh merged commit d2e6fb4 into master Feb 26, 2025
16 checks passed
@j0sh j0sh deleted the ja/remove-analyzeduration branch February 26, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants