Skip to content

update base ubuntu image in Dockerfile#3600

Open
ad-astra-video wants to merge 5 commits intomasterfrom
av/update-go-livepeer-docker-build
Open

update base ubuntu image in Dockerfile#3600
ad-astra-video wants to merge 5 commits intomasterfrom
av/update-go-livepeer-docker-build

Conversation

@ad-astra-video
Copy link
Copy Markdown
Collaborator

@ad-astra-video ad-astra-video commented May 30, 2025

What does this pull request do? Explain your changes. (required)

Update go-livepeer to use ubuntu 22.04 in base image. Ubuntu 22.04 security maintenance expires in April 2027.

I tested on my test gateway and locally noting no issues but more testing should be done.

Should we bump to cuda 12.8 to add Blackwell support? There is no need transcoding related for Blackwell support yet.

Note minimum driver requirements:
image

Specific updates (required)

  • updated Dockerfile and Dockerfile.base
  • added regular cuda path to CPATH, LIBRARY_PATH and CGO_LDFLAGS to enable building without the livepeerci version of the base image

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the docker Pull requests that update Docker code label May 30, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.90540%. Comparing base (507a543) to head (76950de).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3600         +/-   ##
===================================================
+ Coverage   32.88638%   32.90540%   +0.01902%     
===================================================
  Files            171         171                 
  Lines          42063       42063                 
===================================================
+ Hits           13833       13841          +8     
+ Misses         27189       27178         -11     
- Partials        1041        1044          +3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507a543...76950de. Read the comment docs.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszko
Copy link
Copy Markdown
Contributor

leszko commented May 30, 2025

Fine with me, but I see the CI build is failing.

Copy link
Copy Markdown
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, but I see the CI build is failing.

@ad-astra-video
Copy link
Copy Markdown
Collaborator Author

How is the livepeerci/cuda:12.6.3-cudnn-devel-ubuntu22.04 created? I updated the Dockerfile.cuda-base but it does not seem to be creating it?

@leszko
Copy link
Copy Markdown
Contributor

leszko commented Jun 2, 2025

How is the livepeerci/cuda:12.6.3-cudnn-devel-ubuntu22.04 created? I updated the Dockerfile.cuda-base but it does not seem to be creating it?

This is the instruction:

# livepeerci/cuda:12.0.0-cudnn8-devel-ubuntu20.04

Do you have access to push into Docker Hub livepeerci? If not, I can build and push the new image. Let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker Pull requests that update Docker code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants