Skip to content

Serverless#3884

Draft
j0sh wants to merge 16 commits intomasterfrom
ja/serverless
Draft

Serverless#3884
j0sh wants to merge 16 commits intomasterfrom
ja/serverless

Conversation

@j0sh
Copy link
Copy Markdown
Collaborator

@j0sh j0sh commented Mar 19, 2026

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Mar 19, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 3.34572% with 520 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.47783%. Comparing base (48c5d86) to head (be4087c).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
ai/worker/serverless_worker.go 0.00000% 455 Missing ⚠️
cmd/livepeer/starter/starter.go 7.69231% 24 Missing ⚠️
server/ai_http.go 0.00000% 23 Missing ⚠️
trickle/trickle_server.go 44.00000% 14 Missing ⚠️
server/ai_live_video.go 0.00000% 2 Missing ⚠️
cmd/livepeer/starter/flags.go 0.00000% 1 Missing ⚠️
server/ai_session.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3884         +/-   ##
===================================================
- Coverage   32.79594%   32.47783%   -0.31811%     
===================================================
  Files            171         172          +1     
  Lines          41993       42509        +516     
===================================================
+ Hits           13772       13806         +34     
- Misses         27189       27669        +480     
- Partials        1032        1034          +2     
Files with missing lines Coverage Δ
trickle/local_publisher.go 78.57143% <100.00000%> (+56.94981%) ⬆️
cmd/livepeer/starter/flags.go 0.00000% <0.00000%> (ø)
server/ai_session.go 7.43243% <0.00000%> (ø)
server/ai_live_video.go 0.00000% <0.00000%> (ø)
trickle/trickle_server.go 70.73791% <44.00000%> (-1.42425%) ⬇️
server/ai_http.go 9.62567% <0.00000%> (-0.26444%) ⬇️
cmd/livepeer/starter/starter.go 21.68112% <7.69231%> (-0.11375%) ⬇️
ai/worker/serverless_worker.go 0.00000% <0.00000%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c5d86...be4087c. Read the comment docs.

Files with missing lines Coverage Δ
trickle/local_publisher.go 78.57143% <100.00000%> (+56.94981%) ⬆️
cmd/livepeer/starter/flags.go 0.00000% <0.00000%> (ø)
server/ai_session.go 7.43243% <0.00000%> (ø)
server/ai_live_video.go 0.00000% <0.00000%> (ø)
trickle/trickle_server.go 70.73791% <44.00000%> (-1.42425%) ⬇️
server/ai_http.go 9.62567% <0.00000%> (-0.26444%) ⬇️
cmd/livepeer/starter/starter.go 21.68112% <7.69231%> (-0.11375%) ⬇️
ai/worker/serverless_worker.go 0.00000% <0.00000%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j0sh j0sh force-pushed the ja/serverless branch 2 times, most recently from 33a4001 to 5e64de2 Compare March 26, 2026 22:15
mjh1 and others added 16 commits April 1, 2026 18:15
* Don't create pub / sub trickle channels up front since those are
  now created on demand

* Listen to the events channel for payments instead of pub channel
If a client needs to start publishing again and doesn't know where
it left off, then it can add a Lp-Trickle-Reset header along with
the -1 seq ("write next empty segment") which is already supported.

This will unblock any subscribers that may be waiting for hanging
writes from the previous publisher.

Also add a Lp-Trickle-Seq header so publishers can correctly position
their next segment in the stream.

Fix a bookkeeping bug in the LocalPublisher, and add tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants