Conversation
Member
|
Thank you, that was very kind of you! I'm waiting for a bit of time to review it and make a few changes, but basically we're good to go here. I'll also add a comment or two inline now. |
README.md
Outdated
Member
There was a problem hiding this comment.
Don't we want to allow e.g. animate=200, animate=400 in addition to animate=true to optionally specify the duration?
This reverts commit 8ca0340.
Author
|
@andreyvit: Updated. Please review. |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initiated in #11. Rebased and improved.