chore: bump effect-utils lock to 7891e6e#1069
Conversation
Regenerated ci.yml from updated genie template. Updated devenv.lock for latest effect-utils. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad29784560
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57eb252a49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "::warning::nix-store --verify --check-contents reported issues (see diagnostics artifact)" | ||
| fi | ||
| if ! nix-store --verify --check-contents --repair > "$repair_log" 2>&1; then | ||
| echo "::warning::nix-store --verify --check-contents --repair reported issues (see diagnostics artifact)" |
There was a problem hiding this comment.
Upload collected Nix diagnostics before warning about artifacts
This block now redirects resolve_devenv, devenv info, and nix-store output into $DIAG_ROOT, then tells readers to “see diagnostics artifact”, but no step in this workflow uploads $NIX_STORE_DIAGNOSTICS_DIR (existing artifact uploads are for tests/integration/tmp/logs and tmp/ci-docs). In the failure path, the detailed logs are therefore discarded with the runner, which regresses debuggability compared with the previous behavior that still emitted repair output in job logs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good catch — fixed by moving this into the shared effect-utils helper and wiring livestore to it.
- Upstream: nixDiagnosticsArtifactStep added/exported in effect-utils PR refactor(examples): simplify examples #289
- Downstream: this PR now bumps to that effect-utils commit and uses the shared helper in CI generation
This keeps diagnostics capture + upload aligned without local one-off wiring.
Acting on behalf of @schickling.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a37d5bfb33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if: failure() && env.NIX_STORE_DIAGNOSTICS_DIR != '' | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: 'nix-store-diagnostics-${{ github.job }}-${{ runner.os }}-run-${{ github.run_id }}-attempt-${{ github.run_attempt }}' |
There was a problem hiding this comment.
Add matrix key to diagnostics artifact name
In matrix jobs this artifact name is identical across every matrix leg because it only uses ${{ github.job }} and not any matrix dimension, so if multiple legs fail in the same run (test-integration-sync-provider providers or test-integration-playwright suites), actions/upload-artifact@v4 will hit a name collision and later uploads will fail, dropping diagnostics for those failures.
Useful? React with 👍 / 👎.
Summary
devenv.lockandmegarepo.locktooverengineeringstudio/effect-utils@7891e6e64a2f46a193e840f463f375b65ca756a7--no-verifyfor this propagation PR as requested