Refactor mix lvn.install reference #1423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ui for the tutorial
Update to LVN main
bcardarella
reviewed
Sep 17, 2024
| @@ -89,7 +89,7 @@ Follow the [LiveView Native Form Installation Guide](https://github.com/liveview | |||
|
|
|||
| ## Creating a Basic Form | |||
|
|
|||
| The LiveView Native `mix lvn.install` task generates a [core_components.swiftui.ex](https://github.com/liveview-native/liveview-client-swiftui/blob/main/priv/templates/lvn.swiftui.gen/core_components.ex) file for native SwiftUI function components similar to the [core_components.ex](https://github.com/phoenixframework/phoenix/blob/main/priv/templates/phx.gen.live/core_components.ex) file generated in a traditional phoenix application for web function components. | |||
| The LiveView Native `mix lvn.setup.gen` task generates a [core_components.swiftui.ex](https://github.com/liveview-native/liveview-client-swiftui/blob/main/priv/templates/lvn.swiftui.gen/core_components.ex) file for native SwiftUI function components similar to the [core_components.ex](https://github.com/phoenixframework/phoenix/blob/main/priv/templates/phx.gen.live/core_components.ex) file generated in a traditional phoenix application for web function components. | |||
There was a problem hiding this comment.
technically lvn.setup.gen will run all disoverable LVN setup generators. In otherwords, it could run
lvn.stylesheet.setup.grenlvn.jetpack.setup.genlvn.swiftui.setup.gen
If the intent on this paragraph is to re-run just the SwiftUI one then lvn.swiftui.setup.gen would be better. Otherwise it may need to be noted that lvn.setup.gen will also run other setup generators.
/cc @BrooklinJazz ☝️ ?
There was a problem hiding this comment.
@dbii checking back on this
There was a problem hiding this comment.
They need to change or be deleted. If we are keeping them, then I can change it to lvn.swiftui.setup.gen, or I can delete them. @BrooklinJazz should have a better feel for keeping or not based on his knowledge of all the help docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The references to
mix lvn.installare changed. Brooklyn wondered if these sections should be deleted now.