Skip to content

Update state to .setup when live reload is triggered to fix crash #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update state to .setup when live reload is triggered to fix crash #1565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/LiveViewNative/Coordinators/LiveSessionCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ public class LiveSessionCoordinator<R: RootRegistry>: ObservableObject {
let eventListener = self.liveReloadChannel!.channel().events()
self.liveReloadListenerLoop = Task { @MainActor [weak self] in
while !Task.isCancelled {
let event = try await eventListener.event()
let event = try await eventListener.event()
guard let self else { return }
let currentTime = Date()

Expand All @@ -309,6 +309,7 @@ public class LiveSessionCoordinator<R: RootRegistry>: ObservableObject {

if case .user(user: "assets_change") = event.event {
Task { @MainActor in
self.state = .setup
await self.disconnect()
self.navigationPath = [.init(url: self.url, coordinator: .init(session: self, url: self.url), navigationTransition: nil, pendingView: nil)]
await self.connect()
Expand Down
Loading