Skip to content

prevent leak when reconnecting from error view #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

prevent leak when reconnecting from error view #1569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Sources/LiveViewNative/Coordinators/LiveSessionCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,10 @@ public class LiveSessionCoordinator<R: RootRegistry>: ObservableObject {
try await socket.shutdown()
}

if let liveReloadChannel {
try? await liveReloadChannel.shutdownParentSocket()
}

let adapter = ReconnectStrategyAdapter(self.configuration.reconnectBehavior)

self.liveSocket = try await LiveSocket(
Expand Down Expand Up @@ -287,7 +291,7 @@ public class LiveSessionCoordinator<R: RootRegistry>: ObservableObject {
func overrideLiveReloadChannel(channel: LiveChannel) async throws {

if let liveReloadChannel {
try await liveReloadChannel.shutdownParentSocket()
try? await liveReloadChannel.shutdownParentSocket()
self.liveReloadChannel = nil
}

Expand Down
Loading