Fix #649 ffmpeg/info.py incompatible#794
Closed
Omarabdalgwad wants to merge 6 commits intolivingbio:mainfrom
Closed
Fix #649 ffmpeg/info.py incompatible#794Omarabdalgwad wants to merge 6 commits intolivingbio:mainfrom
Omarabdalgwad wants to merge 6 commits intolivingbio:mainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (35.71%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 78.88% 78.80% -0.08%
==========================================
Files 51 51
Lines 3419 3425 +6
==========================================
+ Hits 2697 2699 +2
- Misses 722 726 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…://github.com/Omarabdalgwad/typed-ffmpeg into fix-livingbio#649-ffmpeg/info.py-incompatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes ffmpeg/info.py incompatible in different ffmpeg version
closes #649
1- i have updated parse_codec_flags to correctly parse all codec flags based on ffmpeg
flags_enum = CodecFlags(0) if flags[0] == "D": flags_enum |= CodecFlags.decoding if flags[1] == "E": flags_enum |= CodecFlags.encoding if flags[2] == "V": flags_enum |= CodecFlags.video if flags[3] == "A": flags_enum |= CodecFlags.audio if flags[4] == "S": flags_enum |= CodecFlags.subtitle if flags[5] == "D": flags_enum |= CodecFlags.data if flags[6] == "T": flags_enum |= CodecFlags.attachment if flags[7] == "I": flags_enum |= CodecFlags.intraframe_only if flags[8] == "L": flags_enum |= CodecFlags.lossy if flags[9] == "S": flags_enum |= CodecFlags.lossless return flags_enum2- updated parse_coder_flags to handle encoder or decoder flags consistently