Skip to content

Comments

Add missing docstring to get_cache_path function#809

Merged
lucemia merged 3 commits intomainfrom
copilot/fix-linter-issues
Feb 13, 2026
Merged

Add missing docstring to get_cache_path function#809
lucemia merged 3 commits intomainfrom
copilot/fix-linter-issues

Conversation

Copy link
Contributor

Copilot AI commented Feb 13, 2026

Ruff linter flagged get_cache_path() in src/ffmpeg/common/cache.py for missing docstring (D103 violation).

Changes

  • Added Google-style docstring to get_cache_path() documenting its behavior for both frozen (PyInstaller) and normal execution contexts
Original prompt

This section details on the original issue you should resolve

<issue_title>linter issues?</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 13, 2026 16:19
Co-authored-by: lucemia <432851+lucemia@users.noreply.github.com>
Co-authored-by: lucemia <432851+lucemia@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix linter issues in the codebase Add missing docstring to get_cache_path function Feb 13, 2026
Copilot AI requested a review from lucemia February 13, 2026 16:22
@lucemia lucemia marked this pull request as ready for review February 13, 2026 16:25
@lucemia lucemia enabled auto-merge (squash) February 13, 2026 16:26
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.98%. Comparing base (03b7c35) to head (071770b).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (79.98%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   79.98%   79.98%           
=======================================
  Files          51       51           
  Lines        3432     3432           
=======================================
  Hits         2745     2745           
  Misses        687      687           
Flag Coverage Δ
3.10 79.98% <ø> (ø)
3.11 79.95% <ø> (ø)
3.12 79.95% <ø> (ø)
backend 79.98% <ø> (ø)
python 79.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/ffmpeg/common/cache.py 93.33% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucemia lucemia disabled auto-merge February 13, 2026 17:04
@lucemia lucemia merged commit fe0f86e into main Feb 13, 2026
10 of 11 checks passed
@lucemia lucemia deleted the copilot/fix-linter-issues branch February 13, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter issues?

2 participants