[Breaking] ES2018+: GetIterator, IterableToList, IteratorNext, IteratorStep, IteratorClose: use iterator records instead#68
Draft
ExE-Boss wants to merge 1 commit intoljharb:mainfrom
Conversation
ExE-Boss
force-pushed
the
refactor/es2018/iterator-record
branch
from
2087ccb to
4523a17
Compare
This was referenced Nov 6, 2019
Open
ExE-Boss
force-pushed
the
refactor/es2018/iterator-record
branch
from
4523a17 to
3bae65e
Compare
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 90.89% 89.94% -0.95%
==========================================
Files 670 31 -639
Lines 9444 1781 -7663
Branches 2195 554 -1641
==========================================
- Hits 8584 1602 -6982
+ Misses 860 179 -681
Continue to review full report at Codecov.
|
Owner
|
I rebased #67 but i think this one I'll leave to you :-) |
ExE-Boss
changed the title
IteratorRecord2018+: Convert Iterator operations to use IteratorRecord
…, `IteratorStep`, `IteratorClose`: use iterator records instead
ExE-Boss
force-pushed
the
refactor/es2018/iterator-record
branch
from
40da998 to
cc8ca78
Compare
ExE-Boss
changed the title
2018+: Convert Iterator operations to use IteratorRecordES2018+: GetIterator, IterableToList, IteratorNext, IteratorStep, IteratorClose: use iterator records instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
2018/2019:GetIterator: Addhintparameter #67ES2018+: AddCreateAsyncFromSyncIterator#105BREAKING CHANGE: This is backwards incompatible, as ES2017 and older operated directly on the
Iteratorinstance.