-
-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add opt-in peer location map #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh god this is so cool that's incredible lol |
|
Definitely would love an ENV var that opts in so docker & k8s deployments can update without needing to opt in every time and don't need a data volume mounted |
I initially wanted to do it by environment variable, however, if someone doesn't configure the environment variable but clicks enable map then the only way to keep it persisted is by having a file |
|
Although, it wouldn't be difficult to support both, if opted in via environment variable it doesn't need the enable map and is opted in by default and thus doesn't have to create a file and no mounted volume |
If that PR is merged first will update this one to resolve conflicts and fix any issues |
|
Working on refactor for modularity rewrite #10 |
|
This is super cool, I like it a lot! I have a few concerns though
|
Edit: I should correct myself, the same amount of data would be used but not shared to other people/other people would only see country or see country + city in this specific location being sent, however, since this is a DHT peer-to-peer network, each others IPs are already exposed to each other so direct connections can be established, hyperswarm uses direct peer connections and IPs are in every TCP/UDP packet Theoretically anyone could join the swarm and then get everyone's IPs by querying the DHT without a central authority to stop them, if someone were worried about this they should be using a VPN
|
|
hey @DataDalton given the addition of #20 and #15 we need to make sure we don't clutter the screen with things and keep that nice minimal counter going as it's the core of the application (yes i copy pasted the same message from there lol) Would you be ok to wait until I build a drag modal system to have all elements you want to enable floating on screen and have a button to toggle the map so people can move it around on the screen wherever they want? We can have some nice minimal icons to open the various modals so you can access info whenever you want. Sorry the FE lead in me is coming out making sure we think about user experience and scalability, even if this started as a meme 😆 Let me know, we can work together on this ❤️ |
|
@fccview This has already been moved to a button in the bottom right which clicks to open and shows a minimal map and then can be fullscreened, apologies for not sending new pictures, I'm currently off my computer for the night so I won't be able to send new ones for a while If you'd like you can use the new design until the draggable shared system then I can update this to move to that, but it is now minimal/won't get in the way of those PRs |
|
@DataDalton sorry this is entirely my bad, just pulled the latest code. It looks exactly how i was imagining the system to work, it looks fantastic as is! Let's wait for lklynet and coordinate this with the other pull requests, so much stuff to go in |
|
@fccview Awesome! It's no problem! Since I'll be off for the night (timezones!) it'll be some time before I can make any adjustments to this if needed depending on merge order and potential conflicts |
|
This is a really great idea! Another implementation could be a heatmap of our entire swarm. If users opt-in, their node reports CPU Temperature. We can calculate exactly how much global warming Hypermind is contributing to in real-time. nvm i just looked into requesting cpu temp via docker and no one has time for that. This technically wouldn't have to be opt-in since nobody is requesting or offering anything new, its just the public IP that's already being shared, right? |
|
Trying to fix the conflicts, there's a ton, I can't get the map to show any location in either the branch without conflicts and the one with, so trying to figure out why and what's meant to be looking like to begin with |
check out #20 I added the map, link to open it, and minimize chat |
Right.. I finally fixed all conflicts and got this map working hahaha do we get both maps in? Haven't tried the other branch yet, I'll play with it later lol |
You're correct in that it technically doesn't have to be opt-in and that it's not collecting any data that it doesn't already have, it's more so a best practice. I'm willing to switch to either though depending on what you want, might get more people if we just remove the opting in |
I'm just waking up so it'll be an hour or so until I'm able to aid, if you're willing to wait I can make sure any conflicts are resolved here to be merged |
|
@lklynet Can you make a discord server? It'll make communication a lot easier |
amazing timing lmao |
|
|
Changing to remove the opt-in and just have it always enabled, it's available to everyone anyways, this way we can have a more full map |
|
#36 well fuck. |
Add interactive map showing opted-in peer locations using city-level geolocation.