fix: support workflow_dispatch in commit-recordings via PR metadata artifact (#5202)

## Summary
- Adds `upload-pr-metadata` job to record-integration-tests workflow
that creates an artifact with PR information
- Updates commit-recordings workflow to download and use this metadata
artifact
- Enables workflow_dispatch triggers to properly commit recordings back
to PRs

## Problem
When recording tests are triggered via `workflow_dispatch`, the
commit-recordings companion workflow skips committing because it can't
determine which PR to commit to.

Example of skipped run:
https://github.com/llamastack/llama-stack/actions/runs/23264433521/job/67641289839

## Solution
The record-integration-tests workflow now creates a metadata artifact
containing PR information (number, branch, SHA, repo). The
commit-recordings workflow downloads this artifact and uses it to
determine where to commit, falling back to the original pull_request
event logic if no metadata is found.

## Note
After this merges, the pinned SHAs in record-integration-tests.yml will
need to be updated again to point to the commit that includes this
change.

## Test plan
- [ ] Manual workflow_dispatch trigger should now commit recordings to
the specified PR
- [ ] Auto-trigger on pull_request should continue to work as before

---------

Signed-off-by: Charlie Doern <cdoern@redhat.com>

Author: cdoern

.github/workflows/commit-recordings.yml

@@ -59,43 +59,93 @@ jobs:
             fi
           done
 
-      - name: Get PR information
-        id: pr-info
+      - name: Download PR metadata artifact
         uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7
         with:
           script: |
-            // Get PR number from the triggering workflow
-            const runInfo = await github.rest.actions.getWorkflowRun({
+            const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
               owner: context.repo.owner,
               repo: context.repo.repo,
               run_id: ${{ github.event.workflow_run.id }},
             });
 
+            const metadataArtifact = artifacts.data.artifacts.find(a => a.name.startsWith('pr-metadata-'));
+            if (metadataArtifact) {
+              console.log(`Found PR metadata artifact: ${metadataArtifact.name}`);
+              const download = await github.rest.actions.downloadArtifact({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                artifact_id: metadataArtifact.id,
+                archive_format: 'zip',
+              });
+
+              const fs = require('fs');
+              fs.writeFileSync('pr-metadata.zip', Buffer.from(download.data));
+            } else {
+              console.log('No PR metadata artifact found');
+            }
+
+      - name: Extract PR metadata
+        run: |
+          if [ -f pr-metadata.zip ]; then
+            unzip -o pr-metadata.zip
+            echo "PR metadata contents:"
+            cat pr-info.json
+          else
+            echo "No PR metadata file to extract"
+          fi
+
+      - name: Get PR information
+        id: pr-info
+        uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7
+        with:
+          script: |
+            const fs = require('fs');
             let prNumber = null;
             let headRepo = null;
             let headRef = null;
             let headSha = null;
 
-            // Check if this was triggered by a pull_request event
-            if (runInfo.data.event === 'pull_request' && runInfo.data.pull_requests.length > 0) {
-              const pr = runInfo.data.pull_requests[0];
-              prNumber = pr.number;
+            // Try to load from metadata artifact first
+            if (fs.existsSync('pr-info.json')) {
+              try {
+                const metadata = JSON.parse(fs.readFileSync('pr-info.json', 'utf8'));
+                prNumber = parseInt(metadata.pr_number, 10);
+                headRepo = metadata.pr_head_repo;
+                headRef = metadata.pr_head_ref;
+                headSha = metadata.pr_head_sha;
+                console.log(`Loaded PR info from metadata: PR #${prNumber}`);
+              } catch (e) {
+                console.log(`Failed to parse metadata: ${e.message}`);
+              }
+            }
 
-              // Fetch full PR details
-              const prData = await github.rest.pulls.get({
+            // Fallback: check if triggered by pull_request event
+            if (!prNumber) {
+              const runInfo = await github.rest.actions.getWorkflowRun({
                 owner: context.repo.owner,
                 repo: context.repo.repo,
-                pull_number: prNumber,
+                run_id: ${{ github.event.workflow_run.id }},
               });
 
-              headRepo = prData.data.head.repo.full_name;
-              headRef = prData.data.head.ref;
-              headSha = prData.data.head.sha;
-            } else {
-              // workflow_dispatch - try to extract from run name or skip
-              console.log('Not a pull_request event, skipping commit');
-              core.setOutput('skip', 'true');
-              return;
+              if (runInfo.data.event === 'pull_request' && runInfo.data.pull_requests.length > 0) {
+                const pr = runInfo.data.pull_requests[0];
+                prNumber = pr.number;
+
+                const prData = await github.rest.pulls.get({
+                  owner: context.repo.owner,
+                  repo: context.repo.repo,
+                  pull_number: prNumber,
+                });
+
+                headRepo = prData.data.head.repo.full_name;
+                headRef = prData.data.head.ref;
+                headSha = prData.data.head.sha;
+              } else {
+                console.log('No PR metadata and not a pull_request event, skipping commit');
+                core.setOutput('skip', 'true');
+                return;
+              }
             }
 
             core.setOutput('pr_number', prNumber);

.github/workflows/record-integration-tests.yml

@@ -140,6 +140,39 @@ jobs:
           echo "  Fork PR: ${IS_FORK_PR}"
           echo "  Providers: ${PROVIDERS}"
 
+  # Upload PR metadata for companion workflow
+  upload-pr-metadata:
+    needs: compute-pr-info
+    runs-on: ubuntu-latest
+    steps:
+      - name: Create PR metadata artifact
+        env:
+          # Pass via env vars to prevent code injection (same pattern as compute-pr-info step)
+          PR_NUMBER: ${{ needs.compute-pr-info.outputs.pr_number }}
+          PR_HEAD_REF: ${{ needs.compute-pr-info.outputs.pr_head_ref }}
+          PR_HEAD_SHA: ${{ needs.compute-pr-info.outputs.pr_head_sha }}
+          PR_HEAD_REPO: ${{ needs.compute-pr-info.outputs.pr_head_repo }}
+          IS_FORK_PR: ${{ needs.compute-pr-info.outputs.is_fork_pr }}
+        run: |
+          mkdir -p pr-metadata
+          cat > pr-metadata/pr-info.json <<EOF
+          {
+            "pr_number": "${PR_NUMBER}",
+            "pr_head_ref": "${PR_HEAD_REF}",
+            "pr_head_sha": "${PR_HEAD_SHA}",
+            "pr_head_repo": "${PR_HEAD_REPO}",
+            "is_fork_pr": "${IS_FORK_PR}"
+          }
+          EOF
+          cat pr-metadata/pr-info.json
+
+      - name: Upload PR metadata
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
+        with:
+          name: pr-metadata-${{ github.run_id }}
+          path: pr-metadata/
+          retention-days: 1
+
   # Record tests for each provider
   record-providers:
     needs: compute-pr-info