feat: make distance_metric configurable in vector stores #3375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianZaccaria
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
ChristianZaccaria
force-pushed
the
pr-fix-distance-score
branch
from
b967086 to
a0e0c70
Compare
2 tasks
r3v5
suggested changes
Sep 10, 2025
There was a problem hiding this comment.
Hey @ChristianZaccaria ! Thanks for your PR, nice work. I proposed some improvements.
llama_stack/providers/inline/vector_io/sqlite_vec/sqlite_vec.py
Outdated
Show resolved
Hide resolved
|
I made a comment on the issue. Would like to discuss this more. |
- Configurable distance_metric enabled for PGVector. - Added plumbing to support configuring more distance metrics for each vector provider.
ChristianZaccaria
force-pushed
the
pr-fix-distance-score
branch
from
a0e0c70 to
9658581
Compare
ChristianZaccaria
requested a review
from franciscojavierarceo
as a code owner
ChristianZaccaria
changed the title
| Raises: | ||
| NotImplementedError: If the distance metric is not supported yet | ||
| """ | ||
| if distance_metric != "COSINE": |
There was a problem hiding this comment.
sqlite-vec supports other distance metrics.
see here:
https://github.com/asg017/sqlite-vec/blob/main/site/api-reference.md#distance-functions-distance
but I think it's defined during the table creation: https://github.com/asg017/sqlite-vec/blob/a2dd24f27ec7e4a5743e58f5ab6835deea5db58d/tests/afbd/test-afbd.py#L81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make
distance_metricconfigurable in vector stores:We should create GitHub issues for each provider.
Closes #3213
Test Plan