-
Couldn't load subscription status.
- Fork 1.2k
chore(ci): setup automated stainless builds #3557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(ci): setup automated stainless builds #3557
Conversation
|
Just added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that this can only work when NOT submitting a PR from fork given Github security model on passing secrets to workflow.
@dgellow I'm wondering how this is used elsewhere in practice and how other projects overcome that? Thanks!
|
I'm moving this one back to draft until I have a great documented solution to share |
|
Parts 1, 2, 3, and 4 of https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/ are important reading if we need to find a way to pass a secret into something triggered on every pull request. |
|
Thanks @bbrowning. I actually already read those articles, unfortunately there are a few details that are making the mentioned solutions a no-go for this repo. edit: well, not exactly today, my plane internet is spotty |
0dc7d00 to
a0eb949
Compare
What does this PR do?
This pull request adds a new workflow that does 2 things:
Note
No repo secret
STAINLESS_API_KEYis needed, the authentication is done automatically via GitHub OIDC.Test Plan
I tested in my fork: stainless-api#3