Skip to content

Conversation

@nathan-weinberg
Copy link
Contributor

@nathan-weinberg nathan-weinberg commented Oct 24, 2025

What does this PR do?

this commit adds a new pre-commit hook to scan for non-FIPS compliant function usage within llama-stack

Closes #3427

Test Plan

Ran locally

Copy link
Collaborator

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint failures.

@nathan-weinberg
Copy link
Contributor Author

cc @rhdedgar

@nathan-weinberg nathan-weinberg force-pushed the fips-check branch 2 times, most recently from 688a9a7 to fab936d Compare October 27, 2025 19:16
Copy link
Collaborator

@mattf mattf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be a grep like the asyncio or logging checks?

@franciscojavierarceo
Copy link
Collaborator

can this be a grep like the asyncio or logging checks?
+1

@nathan-weinberg nathan-weinberg force-pushed the fips-check branch 3 times, most recently from c4a5449 to 92234d0 Compare October 28, 2025 14:25
this commit adds a new pre-commit hook to scan for
non-FIPS compliant function usage within llama-stack

Assisted-by: claude-4-sonnet
Signed-off-by: Nathan Weinberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a pre-commit check to avoid using md5sum

4 participants