test: enable telemetry tests in server mode #3927
Merged
+505
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
ehhuang
changed the title
ehhuang
force-pushed
the
pr3926
branch
5 times, most recently
from
b3c9d5a to
1779586
Compare
# What does this PR do? ## Test Plan
ehhuang
requested review from
ashwinb,
bbrowning,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
ashwinb
reviewed
Oct 28, 2025
| docker stop "$container_name" 2>/dev/null || true | ||
| docker rm "$container_name" 2>/dev/null || true | ||
|
|
||
| # Configure telemetry collector port shared between host and container |
There was a problem hiding this comment.
do you not need to run the docker with this additional port mapped or something?
There was a problem hiding this comment.
ah I guess we run it with --network host -- which of course doesn't quite work on a mac :)
ashwinb
approved these changes
Oct 28, 2025
|
Thanks for the view. We'll just go with Jaeger directly as they're already integration tests. |
|
merging first. can remove if/when we add the alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
CI