Skip to content

Conversation

@ehhuang
Copy link
Contributor

@ehhuang ehhuang commented Oct 28, 2025

What does this PR do?

Test Plan

Modify run yaml to use openai files provider:

  files:
  - provider_id: openai
    provider_type: remote::openai
    config:
      api_key: ${env.OPENAI_API_KEY:=}
      metadata_store:
        backend: sql_default
        table_name: openai_files_metadata

# Then run files tests
❯ uv run --no-sync ./scripts/integration-tests.sh --stack-config server:ci-tests --inference-mode replay --setup ollama --suite base --pattern test_files

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 28, 2025
@ehhuang ehhuang force-pushed the pr3946 branch 2 times, most recently from 889ce05 to 23dfa39 Compare October 28, 2025 19:54
# What does this PR do?


## Test Plan
@raghotham
Copy link
Contributor

Maybe not in this PR, but will be good to check to see if we can have multiple files providers in the same server.

Copy link
Collaborator

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ashwinb
Copy link
Contributor

ashwinb commented Oct 28, 2025

Maybe not in this PR, but will be good to check to see if we can have multiple files providers in the same server.

@raghotham @ehhuang yeah for that, we need to get a files router just like the vector_io router (if we don't have one.)

@ehhuang ehhuang merged commit 1f9d48c into main Oct 28, 2025
27 of 45 checks passed
@ehhuang ehhuang deleted the pr3946 branch October 28, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants