Fix error message on failed target attach being discarded#124
Merged
sunshaoce merged 1 commit intolldb-tools:mainfrom Sep 23, 2025
Merged
Fix error message on failed target attach being discarded#124sunshaoce merged 1 commit intolldb-tools:mainfrom
sunshaoce merged 1 commit intolldb-tools:mainfrom
Conversation
Collaborator
|
Nice! Could you also add a test to ensure the error message isn’t empty? |
Contributor
Author
|
@sunshaoce Hi, I don't seem to be able to run the tests on my dev machine: nor do I see source for tests other than a couple for the String class. I'm not sure how to proceed. Could you help me out? |
sunshaoce
approved these changes
Sep 22, 2025
Collaborator
sunshaoce
left a comment
There was a problem hiding this comment.
Lack of testing has always been our problem. I haven’t thought of a good solution for this, so let’s merge it first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the debugger fails to attach to the specified target, such as due to a permission error, then the error message is accidentally discarded. We create an empty
SBStreamon the stack, write nothing to it, and then use its (empty) contents as error message.Instead, this PR removes the empty stream and instead passes the actual error message (as generated by lldb) to the formatted output string, so that it properly shows up in the MI output.