fix to model repo #112
Draft
fix to model repo #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgchn
reviewed
Sep 7, 2025
Gregory-Pereira
force-pushed
the
fixing-model-name-label
branch
from
ffe2f5b to
53c2158
Compare
Signed-off-by: greg pereira <[email protected]>
Gregory-Pereira
force-pushed
the
fixing-model-name-label
branch
from
53c2158 to
488d261
Compare
Signed-off-by: greg pereira <[email protected]>
Gregory-Pereira
force-pushed
the
fixing-model-name-label
branch
from
cd8e267 to
1240679
Compare
jgchn
reviewed
Sep 22, 2025
| matchLabels: | ||
| llm-d.ai/inferenceServing: "true" | ||
| llm-d.ai/model: pd-llm-d-modelservice | ||
| llm-d.ai/model-repo: model |
There was a problem hiding this comment.
Checking values-pd.yaml, shouldn't the output of this example be facebook-opt-125m?
There was a problem hiding this comment.
Yeah this is a bug, what happens is the contexts get nested so it actually loses global values applied from the overlay values file and somehow just gets the default values. Its pulling from random/model and parsing it to grab the repo name of model. Weird behaviour, will convert till draft till I figure it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional, uses model-repo as label instead of release name
cc @jgchn @kalantar