If user set acceleratorResource, respect the value #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added temporary and basic test suite to validate the chart's rendering logic. It is intended as a stopgap solution until a more formal testing framework. |
jgchn
reviewed
Oct 23, 2025
| @@ -0,0 +1,14 @@ | |||
| # Test values for default accelerator resource behavior. | |||
| # The chart should automatically set the GPU count to match tensor parallelism. | |||
There was a problem hiding this comment.
Should the default match tensor x data?
| modelCommand: vllmServe | ||
| resources: | ||
| limits: | ||
| nvidia.com/gpu: "8" # User-defined value |
There was a problem hiding this comment.
Would this still work if I want to set gpu to 0? For example, for vLLM simulators that won't require GPUs but the args would still use tensor-parallel-size=2.
jgchn
reviewed
Oct 23, 2025
Comment on lines
+15
to
+16
| echo "Running Helm template rendering tests..." | ||
| echo "========================================" |
There was a problem hiding this comment.
This is really nice. I wonder if you want to include this as part of the Lint/Test Chart github action workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140