-
Couldn't load subscription status.
- Fork 35
Remove gaie #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove gaie #145
Conversation
Signed-off-by: Michael Kalantar <[email protected]>
Signed-off-by: Michael Kalantar <[email protected]>
|
This should also fix #121. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update chart minor version
Signed-off-by: Michael Kalantar <[email protected]>
Signed-off-by: Michael Kalantar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/lgtm |
Remove gaie components (epp/inferencepool). None of the llm-d guides use ms for deploying gaie. There is an upstream chart defined here: https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/config/charts/inferencepool (released versions at oci://registry.k8s.io/gateway-api-inference-extension/charts/inferencepool) that we would basically be copying if we maintained these pieces.
Also removes creation of HTTPRoute but documents how to do this. HTTPRoutes are really between the gateway and gaie components. There are many ways to create them. We find that except for the simplest cases, users redefine them. An
extraObjectcan be used to include them if desired.Fixes #135.
This is a breaking change.