[Run] Add the ability to upload results to object storage bucket#639
Merged
Vezio merged 2 commits intollm-d:mainfrom Feb 4, 2026
Merged
[Run] Add the ability to upload results to object storage bucket#639Vezio merged 2 commits intollm-d:mainfrom
Vezio merged 2 commits intollm-d:mainfrom
Conversation
Additionally, add several improvements for set_llmdbench_environment.py Signed-off-by: maugustosilva <maugusto.silva@gmail.com>
Signed-off-by: maugustosilva <marcio.a.silva@ibm.com>
mengmeiye
approved these changes
Feb 4, 2026
deanlorenz
reviewed
Feb 5, 2026
Collaborator
deanlorenz
left a comment
deanlorenz
left a comment
There was a problem hiding this comment.
At least in IBM COS, you can restrict ls only to your bucket.
| announce "❌ 'aws' command not found, but is required for 's3://' output." | ||
| exit 1 | ||
| else | ||
| is_bucket=$(aws s3 ls | grep ${_bucket} || true) |
Collaborator
There was a problem hiding this comment.
I am not sure this would always work.
Would probably be better to use aws s3 ls "${_output_destination}"
Your permissions might allow only ls on your own bucket.
| announce "❌ 'gcloud' command not found, but is required for 'gs://' output." | ||
| exit 1 | ||
| else | ||
| is_bucket=$(gcloud storage buckets list | grep ${_bucket} || true) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, add several improvements for set_llmdbench_environment.py
Finally, updated the
vllm-benchmarkandguidellmreleases on the image