feat: Add external plugins support - DO NOT MERGE #183
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| // Package http contains all types of external http plugins | ||
| package http | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "path" | ||
|
|
||
| "github.com/valyala/fasthttp" | ||
|
|
||
| "sigs.k8s.io/controller-runtime/pkg/log" | ||
|
|
||
| "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins" | ||
| "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/types" | ||
| ) | ||
|
|
||
| // Filter implementation of the external http filter | ||
| type Filter struct { | ||
| Plugin | ||
| } | ||
|
|
||
| var _ plugins.Filter = &Filter{} // validate interface conformance | ||
|
|
||
| // NewFilter creates a new instance of external http filter based on the given parameters | ||
| func NewFilter(_ context.Context, name string, url string) plugins.Filter { | ||
| return &Filter{Plugin{name: name, url: url}} | ||
| } | ||
|
|
||
| // Filter filters the given list of pods | ||
| func (f *Filter) Filter(schedContext *types.SchedulingContext, pods []types.Pod) []types.Pod { | ||
| logger := log.FromContext(schedContext).WithName(f.Name()) | ||
|
|
||
| // Create filter http request payload based on the given data | ||
| filterPayload := newFilterPayload(schedContext, pods) | ||
| payload, err := json.Marshal(filterPayload) | ||
|
|
||
| if err != nil { | ||
| logger.Error(err, "Failed to marshal scheduling context, filter will be skipped") | ||
| return pods | ||
| } | ||
|
|
||
| // Create a new fasthttp request and response | ||
| req := fasthttp.AcquireRequest() | ||
| defer fasthttp.ReleaseRequest(req) | ||
| resp := fasthttp.AcquireResponse() | ||
| defer fasthttp.ReleaseResponse(resp) | ||
|
|
||
| req.SetRequestURI(path.Join(f.url, "filter")) | ||
| req.Header.SetMethod(fasthttp.MethodPost) | ||
| req.Header.SetContentType("application/json") | ||
| req.SetBody(payload) | ||
|
|
||
| // Execute the request | ||
| client := &fasthttp.Client{} | ||
| if err := client.Do(req, resp); err != nil { | ||
| logger.Error(err, "request failed") | ||
| return pods | ||
| } | ||
|
|
||
| // Optionally check status code | ||
| if resp.StatusCode() != fasthttp.StatusOK { | ||
| logger.Error(nil, fmt.Sprintf("bad response status: %d, body: %s", resp.StatusCode(), resp.Body())) | ||
| return pods | ||
| } | ||
|
|
||
| var filteredPodNames []namespacedName | ||
|
|
||
| // filter plugin response is an array of pod full names | ||
| if err := json.Unmarshal(resp.Body(), &filteredPodNames); err != nil { | ||
| logger.Error(err, "external filter's response body unmarshal failed", "name", f.Name(), "resp body", resp.Body()) | ||
| return pods | ||
| } | ||
|
|
||
| // filter list of given pods based on the returned list of pods | ||
| podsNamesSet := map[string]bool{} | ||
|
|
||
| for _, nn := range filteredPodNames { | ||
| podsNamesSet[namespacedNameToString(nn.Name, nn.Namespace)] = true | ||
| } | ||
|
|
||
| filteredPods := make([]types.Pod, 0) | ||
|
|
||
| for _, p := range pods { | ||
| nn := p.GetPod().NamespacedName | ||
| if _, exists := podsNamesSet[namespacedNameToString(nn.Name, nn.Namespace)]; exists { | ||
| filteredPods = append(filteredPods, p) | ||
| } | ||
| } | ||
|
|
||
| return filteredPods | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package http | ||
|
|
||
| // Plugin common information for external http plugin | ||
| type Plugin struct { | ||
| name string | ||
| url string | ||
| } | ||
|
|
||
| // Name returns the plugin's name | ||
| func (s *Plugin) Name() string { | ||
| return s.name | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: what's the benefit of using a non standard HTTP implementation? If performance, then we should first prove that HTTP handling is a bottleneck.