Add Prow GitHub Actions #290
Conversation
Jooho
requested review from
kfirtoledo,
kfswain,
nilig,
nirrozenbaum,
shmuelk and
elevran
as code owners
| @@ -0,0 +1,15 @@ | |||
| approvers: | |||
There was a problem hiding this comment.
out of curiosity, will this work with OWNER_ALIASES file also?
e.g., like this one:
https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/OWNERS_ALIASES
There was a problem hiding this comment.
Yea I think we can use it. I added the file
|
@Jooho - thanks! |
|
@Jooho merging is blocked due to commit signature not verified. |
Jooho
force-pushed
the
prow_ci
branch
2 times, most recently
from
f084766 to
fd6a04c
Compare
|
@nirrozenbaum I rebased and amened :) |
|
@Jooho hate to nag, we required verified signatures. your commit is signed but your signature is not verified. |
Jooho
force-pushed
the
prow_ci
branch
2 times, most recently
from
870f397 to
b8ec73f
Compare
|
@nirrozenbaum oh.. right my gpg key was expired before. I extended the date so now it should show a |
|
interesting.. it was gone again after a few mins.. let me check it again. |
|
I hope that this time it works |
Signed-off-by: Jooho Lee <[email protected]> follw up comments Signed-off-by: Jooho Lee <[email protected]>
|
Ok, I figured out what caused the issue. When I rebased via the GitHub workflow button, the Verified badge disappeared, so I did a rebase first and then amended the commit again. |
|
By the way, I don’t understand why the workflow isn’t triggered, even though this isn’t the first PR. |
Issue: #148
This commit adds GitHub Actions workflows for Prow CI/CD pipeline, including the following files: