Add build metadata to Docker image #292
Conversation
carlory
requested review from
kfirtoledo,
kfswain,
nilig,
nirrozenbaum,
shmuelk and
elevran
as code owners
|
I'm not sure whether I should get the git information of llm-d or the git information of GIE which is from go mod |
carlory
force-pushed
the
fix-image-build
branch
from
e7a4dd3 to
2a952c1
Compare
| RUN go build -a -o bin/epp -ldflags="-extldflags '-L$(pwd)/lib'" cmd/epp/main.go | ||
| ARG COMMIT_SHA=unknown | ||
| ARG BUILD_REF | ||
| RUN go build -a -o bin/epp -ldflags="-extldflags '-L$(pwd)/lib' -X sigs.k8s.io/gateway-api-inference-extension/pkg/epp/metrics.CommitSHA=${COMMIT_SHA} -X sigs.k8s.io/gateway-api-inference-extension/pkg/epp/metrics.BuildRef=${BUILD_REF}" cmd/epp/main.go |
There was a problem hiding this comment.
The correct fields to set are sigs.k8s.io/gateway-api-inference-extension/version.CommitSHA and sigs.k8s.io/gateway-api-inference-extension/version.BuildRef.
Thus the command should be:
RUN go build -a -o bin/epp -ldflags="-extldflags '-L$(pwd)/lib' -X sigs.k8s.io/gateway-api-inference-extension/version.CommitSHA=${COMMIT_SHA} -X sigs.k8s.io/gateway-api-inference-extension/version.BuildRef=${BUILD_REF}" cmd/epp/main.go
There was a problem hiding this comment.
@shmuelk v0.5.1 doesn't have the version package.
There was a problem hiding this comment.
right. this change (moving the fields to package version) was done post v0.5.1 release 👍
There was a problem hiding this comment.
Please rebase and sign your commit and then I'll happily approve and merge this change.
carlory
force-pushed
the
fix-image-build
branch
from
2a952c1 to
cc6bf43
Compare
|
Thanks for the rebase. Please go to your github settings and verify your signature. While you have signed your commits, they are not verified by github. We require verified signatures. |
Signed-off-by: carlory <[email protected]>
carlory
force-pushed
the
fix-image-build
branch
from
cc6bf43 to
7a18cdb
Compare
|
@shmuelk thanks for your guide. |
Uh oh!
There was an error while loading. Please reload this page.