-
Notifications
You must be signed in to change notification settings - Fork 83
chore: drop plugin type from types and file #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c0da950
to
fb7ea9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments might still need the use of filter/scorer in them.
@yyzxw thanks for the contribution! |
fb7ea9c
to
6827d97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
thank you for following up on the review comments. |
6827d97
to
b937ab2
Compare
Signed-off-by: zxw <[email protected]>
b937ab2
to
d4b8c91
Compare
all commits are signed now. |
/lgtm |
close: #19