Add configurable prefill port support to prefill-header-handler plugin #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallavijaini0525
force-pushed
the
prefillheader-port
branch
from
547e356 to
0f3b836
Compare
|
/rebase |
|
@pallavijaini0525 the PR is failing CI (linting) - kindly rebase and fix before we can move it forward. |
Signed-off-by: pallavi jaini <[email protected]>
Signed-off-by: pallavi jaini <[email protected]>
Signed-off-by: pallavi jaini <[email protected]>
pallavijaini0525
force-pushed
the
prefillheader-port
branch
from
0f3b836 to
d51298c
Compare
Signed-off-by: Pallavi Jaini <[email protected]>
|
@elevran -> Lint issues are fixed. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prefill/decode (PD) disaggregation deployments, the prefill-header-handler plugin using the same targetPort for both the routing sidecar and prefill nodes. This resulted in incorrect x-prefiller-host-port headers being generated when prefill is running on a different port, preventing proper communication between decode and prefill workers.
Added an optional prefillTargetPort parameter to the prefill-header-handler plugin configuration. When specified, this parameter overrides the generic targetPort when constructing the x-prefiller-host-port header.