test: Scale up and down the model server during an end to end test #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmuelk
force-pushed
the
scale-up-down-test
branch
from
8f159b3 to
22c5fa8
Compare
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
shmuelk
force-pushed
the
scale-up-down-test
branch
from
cd7e869 to
793c1de
Compare
elevran
requested changes
Oct 20, 2025
| }) | ||
|
|
||
| ginkgo.When("Scaling up and down the model servers", func() { | ||
| ginkgo.It("work should be distributed across all model servers", func() { |
There was a problem hiding this comment.
nit: if using ginkgo.It the text should probably align with that...
Suggested change
| ginkgo.It("work should be distributed across all model servers", func() { | |
| ginkgo.It("should distribute inference requests across all model servers", func() { |
| epp := createEndPointPicker(scaleConfig) | ||
|
|
||
| prefillPods, decodePods := getModelServerPods(podSelector, prefillSelector, decodeSelector) | ||
| gomega.Expect(prefillPods).Should(gomega.BeEmpty()) |
There was a problem hiding this comment.
when is the goal of validating that there are no prefill Pods?
Can it somehow fail and if so, how does a failure affect the test if at all?
| scaleDeployment(modelServers, 1) | ||
|
|
||
| scaledUpPrefillPods, scaledUpDecodePods := getModelServerPods(podSelector, prefillSelector, decodeSelector) | ||
| gomega.Expect(scaledUpPrefillPods).Should(gomega.BeEmpty()) |
Comment on lines
+153
to
+155
| gomega.Expect(scaledUpDecodePods).Should(gomega.HaveLen(2)) | ||
|
|
||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
might it be worthwhile to check that pods are in ready state and not rely on the 1s sleep?
Or maybe there's a different reason for sleeping...?
| scaleDeployment(modelServers, -1) | ||
|
|
||
| scaledDownPrefillPods, scaledDownDecodePods := getModelServerPods(podSelector, prefillSelector, decodeSelector) | ||
| gomega.Expect(scaledDownPrefillPods).Should(gomega.BeEmpty()) |
| gomega.Expect(scaledDownDecodePods).Should(gomega.HaveLen(1)) | ||
| gomega.Expect(scaledDownDecodePods[0]).Should(gomega.BeElementOf(scaledUpDecodePods)) | ||
|
|
||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
same. Expect on a condition (with Eventually...) would be quicker.
|
|
||
| scale.Spec.Replicas += int32(increment) | ||
| _, err = client.AppsV1().Deployments(nsName).UpdateScale(ctx, split[1], scale, v1.UpdateOptions{}) | ||
| gomega.Expect(err).NotTo(gomega.HaveOccurred()) |
There was a problem hiding this comment.
the scale change can have succeeded but the replica count not have increased or the new pods not ready (or deleted) yet...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test to the end to tests.
In particular it adds a test in which:
Fixes: #347