Fix multi-architecture image issues with Kind #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elevran
previously approved these changes
Oct 20, 2025
test/e2e/e2e_suite_test.go
Outdated
| command = exec.Command("kind", "--name", "e2e-tests", "load", "docker-image", | ||
| "ghcr.io/llm-d/llm-d-inference-scheduler:"+eppTag) | ||
| session, err = gexec.Start(command, ginkgo.GinkgoWriter, ginkgo.GinkgoWriter) | ||
| func kindLoad(image string) { |
There was a problem hiding this comment.
nit: perhaps kindLoadImage?
|
|
||
| ginkgo.By(fmt.Sprintf("Loading %s into the cluster e2e-tests", image)) | ||
|
|
||
| command := exec.Command("docker", "save", "--platform", "linux/"+runtime.GOARCH, |
There was a problem hiding this comment.
nit: perhaps define target := tempDir+"/docker.tar" and then reuse in L134 and L139.
Signed-off-by: Shmuel Kallner <[email protected]>
Signed-off-by: Shmuel Kallner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Kind use containerd under the covers in the simulated K8S nodes.
There is a known incompatibility between Docker and containerd with respect to multi-platform images. Docker doesn't pull al of the layers of such images. It only pulls the layers that are applicable to the platform (i.e. AMD64 or ARM64) in question. Containerd then issues an error about missing layers.
See kubernetes-sigs/kind#3795 for more details.
This PR replaces the command
kind load docker-image...withdocker saveandkind load image-archive. The docker save is done specifying the local platform, to only save for the appropriate platform.