-
Notifications
You must be signed in to change notification settings - Fork 105
Enhance golangci-lint configuration for improved code quality #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rishi Jat <[email protected]>
|
/cc @elevran |
|
🚨 Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, |
3b7ed17 to
e8ca43b
Compare
Signed-off-by: Rishi Jat <[email protected]>
e8ca43b to
ee37345
Compare
|
hey @elevran i did the suggested changes but idk why |
|
The commit is signed but the signature could not be verified. This means you either did not add a public key to github or did not signt the actual commit before pushing. Please follow these steps and substitute the correct f Enable signature verification
Future Git commits you create will show as “Verified” on GitHub using your SSH key signature. Recreate PR from scratch and submitThe simplest is to close this PR and redo the change after after you have configured verified signing and rebased your code on Alternative (more work unless you're familair with Git interactive rebase)It's possible to amend this PR to contain verified signatures, but it's more steps. This is described below. To sign the current PR commits git rebase -i HEAD~2In the list of commits that will be displayed, change each Then for each commit: git commit --amend --S
git rebase --continueand finally push: git push --force-with-leaseThis will properly sign all commits and update the PR. |
fixes #149