Skip to content

Conversation

@rishi-jat
Copy link

@rishi-jat rishi-jat commented Nov 28, 2025

fixes #149

Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat
Copy link
Author

/cc @elevran

@github-actions github-actions bot requested a review from elevran November 28, 2025 11:24
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🚨 Unsigned commits detected! Please sign your commits.

For instructions on how to set up GPG/SSH signing and verify your commits,
please see GitHub Documentation.

@rishi-jat rishi-jat force-pushed the enhance/golangci-lint-clean branch 2 times, most recently from 3b7ed17 to e8ca43b Compare December 2, 2025 11:33
Signed-off-by: Rishi Jat <[email protected]>
@rishi-jat rishi-jat force-pushed the enhance/golangci-lint-clean branch from e8ca43b to ee37345 Compare December 2, 2025 11:36
@rishi-jat
Copy link
Author

hey @elevran i did the suggested changes but idk why check Signed commit in PR check is failing can you tell me how i can fix this ? Thanks!

@elevran
Copy link
Collaborator

elevran commented Dec 2, 2025

The commit is signed but the signature could not be verified. This means you either did not add a public key to github or did not signt the actual commit before pushing. Please follow these steps and substitute the correct f

Enable signature verification

  1. Generate an SSH key with a signing capability:
    ssh-keygen -t ed25519 -C "<your_email>" -f ~/.ssh/id_ed25519
    The last value is the base file name used to store the key. It'll create two files: <file> (private key) and <file>.pub (public key) under the path (e.g., ~/.ssh in the example above).

  2. Add the public key as a “SSH signing key” in GitHub.
    GitHub → Settings → SSH and GPG keys → New SSH signing key.
    Make sure you upload the public key file content and not private key file an select Signing Key under Key Type.

  3. In a local terminal, tell Git to use your SSH private key for commit signing:
    git config --global gpg.format ssh
    git config --global user.signingkey ~/.ssh/id_ed25519
    The signing key values should contain the path of the private key created in step 1.

  4. Enable automatic signing of commits (for future commits):
    git config --global commit.gpgsign true

Future Git commits you create will show as “Verified” on GitHub using your SSH key signature.

Recreate PR from scratch and submit

The simplest is to close this PR and redo the change after after you have configured verified signing and rebased your code on main.
Save the final form of the configuration file with all changes reflecting the review comments.

Alternative (more work unless you're familair with Git interactive rebase)

It's possible to amend this PR to contain verified signatures, but it's more steps. This is described below.

To sign the current PR commits
Use interactive rebase (assume we want to change the last 2 commits which are part of this PR):

git rebase -i HEAD~2

In the list of commits that will be displayed, change each pick to edit

Then for each commit:

git commit --amend --S
git rebase --continue

and finally push:

git push --force-with-lease

This will properly sign all commits and update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Review (and expand, if needed) golangci-lint configuration

2 participants