feat: Add multi-modality support for content blocks in PrecisePrefixCacheScorer#565
Open
guygir wants to merge 4 commits intollm-d:mainfrom
Open
feat: Add multi-modality support for content blocks in PrecisePrefixCacheScorer#565guygir wants to merge 4 commits intollm-d:mainfrom
guygir wants to merge 4 commits intollm-d:mainfrom
Conversation
…fixCacheScorer, and a basic test script for e2e multi-modality inputs Signed-off-by: Guy Girmonsky <guygir@gmail.com>
Remove redundant \n from fmt.Println string literal (fmt.Println already adds newline) Signed-off-by: Guy Girmonsky <guygir@gmail.com>
Rename test_e2e_multimodality.go to test_multimodality_conversion.go. This test verifies conversion logic (GAIE parsing + format conversion), not the full end-to-end pipeline. Signed-off-by: Guy Girmonsky <guygir@gmail.com>
Update print statements to say 'conversion logic test' instead of 'end-to-end test' Signed-off-by: Guy Girmonsky <guygir@gmail.com>
bb7a5e4 to
78096a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Depends on llm-d/llm-d-kv-cache#255. This PR should not be merged until the kv-cache PR is merged first.
This PR extends the PrecisePrefixCacheScorer to preserve structured multi-modality content blocks (OpenAI API format) through the pipeline.
This is the first stage of multi-modality support - only basic technical feasibility. This PR focuses solely on images - not audio or video, because GAIE already supports images but audio/video support requires additional GAIE changes (These will be addressed in the next stage)
Changes:
What Works:
Known Limitations (for current stage):
Testing: