Skip to content

Fix: Rand generator is not set in a test suite which result in accessing nil pointer during runtime if run the only test suite #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

Fix: Rand generator is not set in a test suite which result in accessing nil pointer during runtime if run the only test suite #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbab71d
Add make flag to filter test case
pancak3 Aug 25, 2025
fbf06bd
Init random generator in Check random latencies test suite
pancak3 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,11 @@ format: ## Format Go source files
.PHONY: test
test: check-ginkgo download-tokenizer download-zmq ## Run tests
@printf "\033[33;1m==== Running tests ====\033[0m\n"
ifdef GINKGO_FOCUS
CGO_ENABLED=1 ginkgo -ldflags="$(GO_LDFLAGS)" -v -r --focus="$(GINKGO_FOCUS)"
else
CGO_ENABLED=1 ginkgo -ldflags="$(GO_LDFLAGS)" -v -r
endif

.PHONY: post-deploy-test
post-deploy-test: ## Run post deployment tests
Expand Down
3 changes: 3 additions & 0 deletions pkg/llm-d-inference-sim/simulator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"net/http"
"os"
"strings"
"time"

"github.com/llm-d/llm-d-inference-sim/pkg/common"
. "github.com/onsi/ginkgo/v2"
Expand Down Expand Up @@ -754,6 +755,8 @@ var _ = Describe("Simulator", func() {
KVCacheTransferLatency: 2048,
KVCacheTransferLatencyStdDev: 2048,
}

common.InitRandom(time.Now().UnixNano())
})

DescribeTable("should calculate inter token latency correctly",
Expand Down