Skip to content

DP bug fix: wait after starting rank 0 sim #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

DP bug fix: wait after starting rank 0 sim #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f39f3f2
Wait after starting rank 0 sim
irar2 Sep 9, 2025
a77c8c5
Start rank 0 similar to others
irar2 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions pkg/llm-d-inference-sim/simulator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ func (s *VllmSimulator) Start(ctx context.Context) error {
}

// For Data Parallel, start data-parallel-size - 1 additional simulators
g, ctx := errgroup.WithContext(ctx)
if s.config.DPSize > 1 {
g, ctx := errgroup.WithContext(context.Background())
for i := 2; i <= s.config.DPSize; i++ {
newConfig, err := s.config.Copy()
if err != nil {
Expand All @@ -170,12 +170,15 @@ func (s *VllmSimulator) Start(ctx context.Context) error {
return newSim.startSim(ctx)
})
}
if err := g.Wait(); err != nil {
return err
}
s.logger = klog.LoggerWithValues(s.logger, "rank", 0)
}
return s.startSim(ctx)
g.Go(func() error {
return s.startSim(ctx)
})
if err := g.Wait(); err != nil {
return err
}
return nil
}

func (s *VllmSimulator) startSim(ctx context.Context) error {
Expand Down
Loading