Skip to content

fix(make): properly resolves package manager for ZMQ installation #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

fix(make): properly resolves package manager for ZMQ installation #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-pr-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Install libzmq dependencies (kvcache/kvevents)
run: |
sudo apt-get update
sudo apt-get install -y libzmq3-dev pkg-config
make download-zmq

- name: Set PKG_CONFIG_PATH
run: echo "PKG_CONFIG_PATH=/usr/lib/pkgconfig" >> $GITHUB_ENV
Expand Down
20 changes: 10 additions & 10 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,29 +241,29 @@ install-hooks: ## Install git hooks

.PHONY: download-zmq
download-zmq: ## Install ZMQ dependencies based on OS/ARCH
@echo "Checking if ZMQ is already installed..."
@echo "⏳ Checking if ZMQ is already installed..."
@if pkg-config --exists libzmq; then \
echo "✅ ZMQ is already installed."; \
else \
echo "Installing ZMQ dependencies..."; \
echo "⏳ Installing ZMQ dependencies..."; \
if [ "$(TARGETOS)" = "linux" ]; then \
if [ -x "$(command -v apt)" ]; then \
apt update && apt install -y libzmq3-dev; \
elif [ -x "$(command -v dnf)" ]; then \
dnf install -y zeromq-devel; \
if command -v apt >/dev/null 2>&1; then \
sudo apt update && sudo apt install -y libzmq3-dev; \
elif command -v dnf >/dev/null 2>&1; then \
sudo dnf install -y zeromq-devel; \
else \
echo "Unsupported Linux package manager. Install libzmq manually."; \
echo -e "⚠️ Unsupported Linux package manager. Follow installation guides: https://github.com/zeromq/libzmq#installation-of-binary-packages-\n"; \
exit 1; \
fi; \
elif [ "$(TARGETOS)" = "darwin" ]; then \
if [ -x "$(command -v brew)" ]; then \
if command -v brew >/dev/null 2>&1; then \
brew install zeromq; \
else \
echo "Homebrew is not installed and is required to install zeromq. Install it from https://brew.sh/"; \
echo "⚠️ Homebrew is not installed and is required to install zeromq. Install it from https://brew.sh/"; \
exit 1; \
fi; \
else \
echo "Unsupported OS: $(TARGETOS). Install libzmq manually - check https://zeromq.org/download/ for guidance."; \
echo "⚠️ Unsupported OS: $(TARGETOS). Install libzmq manually - see https://zeromq.org/download/"; \
exit 1; \
fi; \
echo "✅ ZMQ dependencies installed."; \
Expand Down