feat: add support for X-Request-Id header in responses and logs #269
+165
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayabar
requested changes
Dec 7, 2025
Collaborator
mayabar
left a comment
mayabar
left a comment
There was a problem hiding this comment.
Thanks for the PR, please see some comments
rudeigerc
force-pushed
the
feat/request-id
branch
from
e0e36e2 to
dc941e7
Compare
Contributor
Author
|
@mayabar Thanks for the review! The addressed issues have been updated. |
rudeigerc
force-pushed
the
feat/request-id
branch
from
dc941e7 to
3823ef9
Compare
mayabar
reviewed
Dec 8, 2025
Collaborator
mayabar
left a comment
mayabar
left a comment
There was a problem hiding this comment.
/lgtm
@rudeigerc Please fix the lint problem
rudeigerc
force-pushed
the
feat/request-id
branch
from
3823ef9 to
20cc725
Compare
Signed-off-by: rudeigerc <[email protected]>
rudeigerc
force-pushed
the
feat/request-id
branch
from
20cc725 to
fbaa66a
Compare
Contributor
Author
Collaborator
|
/lgtm |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
X-Request-Idheader, enabling request tracing across the LLM inference simulation server, aligning with extra HTTP headers of vLLM's OpenAI-compatible server feature. The update also provides the--enable-request-id-headersflag that vLLM offers.Related vLLM PRs:
add_request_idmiddleware vllm-project/vllm#9594Currently, only
X-Request-Idis supported sincectx.Request.Header.Peekfrom fasthttp is case-sensitive.