Initial distributed tracing instrumentation #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallyom
force-pushed
the
tracing
branch
2 times, most recently
from
3342ece to
74dac2d
Compare
frzifus
reviewed
Jul 31, 2025
| attribute.String(tracing.AttrOperationOutcome, tracing.OutcomeSuccess), | ||
| ) | ||
| tracing.SetSpanError(findTokensSpan, nil) | ||
| findTokensSpan.End() |
There was a problem hiding this comment.
Does it make sense to wrap the FindLongestContainedTokens operation to set the attributes move it to the actual implementation? Missing the End() in the future can be easy.
|
|
||
| var hitRatio float64 | ||
| if totalPods > 0 { | ||
| hitRatio = float64(len(podScores)) / float64(totalPods) |
- Add OpenTelemetry distributed tracing support to kv-cache-manager - Instrument Redis operations with automatic OTel tracing and metrics Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial distributed tracing instrumentation
Also, fix nil pointer dereference in KV Cache scorer initialization.