-
Notifications
You must be signed in to change notification settings - Fork 78
refactor: convert profiling script to standard go benchmark #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c47f562 to
805bc30
Compare
- Replaced standalone main.go with index_benchmark_test.go for better CI integration. - Implemented fixed random seed to ensure identical workloads across all index implementations. - Added 'miniredis' integration to make Redis benchmarks self-contained. - Updated 'index.Add' usage to match the current interface signature. - Added clarifying comments regarding empty pod set lookups.
805bc30 to
0c80679
Compare
Collaborator
|
Would it be better to add a README to describe how to run it? |
Contributor
Author
|
@yankay That makes sense, I added a README |
Collaborator
Thanks @kaushik-rohit It's a great change :-) The test result on my PC: |
yankay
approved these changes
Jan 19, 2026
Collaborator
|
HI @sagearc @hyeongyun0916 @liu-cong @vMaroon Would you please help to review it :-) |
Member
|
Thanks @kaushik-rohit, @yankay, apologies for delay. /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#108
Building on previous PR #175, I updated the code to be standard Go benchmarking and addressed the comments in that PR.
Profiling run: