This repository was archived by the owner on Jul 24, 2025. It is now read-only.
expose LoadFormat in TemplateVars to enable runai-streamer templates#221
Open
nerdalert wants to merge 1 commit intollm-d:mainfrom
Open
expose LoadFormat in TemplateVars to enable runai-streamer templates#221nerdalert wants to merge 1 commit intollm-d:mainfrom
LoadFormat in TemplateVars to enable runai-streamer templates#221nerdalert wants to merge 1 commit intollm-d:mainfrom
Conversation
Adds a LoadFormat field to TemplateVars and populates it from .Spec.ModelArtifacts.LoadFormat, letting the controller render ConfigMap templates for --load-format. Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
nerdalert
force-pushed
the
load-format-var
branch
from
ffc0f66 to
ab7fc4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a LoadFormat field to TemplateVars and populates it from .Spec.ModelArtifacts.LoadFormat, letting the controller render ConfigMap templates for --load-format.
This relates to the issue: llm-d/llm-d-deployer#317
And relates to the PR: llm-d/llm-d-deployer#318
Deployer is on
v0.0.10. Will get some validation from jerms on his PR but I think this is the only workaround for the preset configmap. Ty!