Skip to content

Comments

cleanup: move indexers to controller/indexers#766

Open
lionelvillard wants to merge 1 commit intollm-d:mainfrom
lionelvillard:pr/lionelvillard/686
Open

cleanup: move indexers to controller/indexers#766
lionelvillard wants to merge 1 commit intollm-d:mainfrom
lionelvillard:pr/lionelvillard/686

Conversation

@lionelvillard
Copy link
Collaborator

No description provided.

Signed-off-by: Lionel Villard <villard@us.ibm.com>
Copilot AI review requested due to automatic review settings February 19, 2026 21:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relocates the VariantAutoscaling field indexer helpers into internal/controller/indexers, updates call sites/imports accordingly, and adjusts related tests and module metadata to reflect the refactor.

Changes:

  • Moved indexer utilities into internal/controller/indexers and updated imports/usages across controller/collector and main wiring.
  • Added/updated envtest-based tests for the new indexers package and fixed relative paths after the move.
  • Applied gofmt/tidy-style cleanup in several tests and dependency files.

Reviewed changes

Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/e2e-openshift/sharegpt_scaleup_test.go gofmt-style string concatenation cleanup in metric query path building.
test/e2e-openshift/scale_to_zero_test.go gofmt-style alignment/formatting cleanup.
test/chart/client_only_install_test.go gofmt-style map literal alignment/formatting cleanup.
internal/engines/saturation/engine.go Import ordering cleanup.
internal/controller/variantautoscaling_controller.go Updated import to new indexers package location.
internal/controller/indexers/suite_test.go Updated envtest CRD/binary relative paths due to new directory depth.
internal/controller/indexers/indexers_test.go Added envtest coverage for index registration and lookup behavior.
internal/controller/indexers/indexers.go New indexers package: index registration + lookup helpers keyed by scale target.
internal/collector/source/pod_va_mapper_test.go Updated import to new indexers package location.
internal/collector/source/pod_va_mapper.go Updated import to new indexers package location.
cmd/main.go Updated import and wiring to call indexers.SetupIndexes from new location.
go.mod Promoted gonum to a direct dependency.
go.sum Removed old gonum checksums and kept current version entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant