cleanup: move indexers to controller/indexers#766
Open
lionelvillard wants to merge 1 commit intollm-d:mainfrom
Open
cleanup: move indexers to controller/indexers#766lionelvillard wants to merge 1 commit intollm-d:mainfrom
lionelvillard wants to merge 1 commit intollm-d:mainfrom
Conversation
Signed-off-by: Lionel Villard <villard@us.ibm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates the VariantAutoscaling field indexer helpers into internal/controller/indexers, updates call sites/imports accordingly, and adjusts related tests and module metadata to reflect the refactor.
Changes:
- Moved indexer utilities into
internal/controller/indexersand updated imports/usages across controller/collector and main wiring. - Added/updated envtest-based tests for the new indexers package and fixed relative paths after the move.
- Applied gofmt/tidy-style cleanup in several tests and dependency files.
Reviewed changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
test/e2e-openshift/sharegpt_scaleup_test.go |
gofmt-style string concatenation cleanup in metric query path building. |
test/e2e-openshift/scale_to_zero_test.go |
gofmt-style alignment/formatting cleanup. |
test/chart/client_only_install_test.go |
gofmt-style map literal alignment/formatting cleanup. |
internal/engines/saturation/engine.go |
Import ordering cleanup. |
internal/controller/variantautoscaling_controller.go |
Updated import to new indexers package location. |
internal/controller/indexers/suite_test.go |
Updated envtest CRD/binary relative paths due to new directory depth. |
internal/controller/indexers/indexers_test.go |
Added envtest coverage for index registration and lookup behavior. |
internal/controller/indexers/indexers.go |
New indexers package: index registration + lookup helpers keyed by scale target. |
internal/collector/source/pod_va_mapper_test.go |
Updated import to new indexers package location. |
internal/collector/source/pod_va_mapper.go |
Updated import to new indexers package location. |
cmd/main.go |
Updated import and wiring to call indexers.SetupIndexes from new location. |
go.mod |
Promoted gonum to a direct dependency. |
go.sum |
Removed old gonum checksums and kept current version entries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.