feat: add plot-batch manifest and shared plot data loader#123
Open
claytonlin1110 wants to merge 2 commits intollmsresearch:mainfrom
Open
feat: add plot-batch manifest and shared plot data loader#123claytonlin1110 wants to merge 2 commits intollmsresearch:mainfrom
claytonlin1110 wants to merge 2 commits intollmsresearch:mainfrom
Conversation
Contributor
Author
|
@dippatel1994 Any update about this feature? |
Contributor
Author
|
@dippatel1994 Please review |
dippatel1994
requested changes
Apr 2, 2026
Member
dippatel1994
left a comment
There was a problem hiding this comment.
CI passes, clean extraction of shared data loader. One behavioral concern:
- JSON data unwrapping regression — Old Studio
run_plothadraw_data = raw if isinstance(raw, list) else raw.get("data", raw)which unwrapped a{"data": [...]}envelope. Newload_statistical_plot_payload()returns raw JSON as-is, then callers wrap asraw_data={"data": payload}. If a user passes{"data": [{"x":1}]}, old code producesraw_data={"data": [...]}(unwrapped), new code producesraw_data={"data": {"data": [...]}}(double-wrapped). Decide which behavior is correct and be consistent.
Non-blocking: total_seconds missing from Studio run_plot_batch report (always shows 0.0s). Pre-existing pattern but easy to fix here. Also no test for empty manifest handling.
Contributor
Author
|
@dippatel1994 Just updated. |
dippatel1994
approved these changes
Apr 2, 2026
Member
dippatel1994
left a comment
There was a problem hiding this comment.
JSON unwrapping regression fixed, total_seconds added to Studio report, empty manifest test added. CI green. LGTM.
Contributor
Author
|
Thanks @dippatel1994 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
paperbanana plot-batchso multiple statistical plots (CSV/JSON + intent) can run in one batch with the sameoutputs/batch_*layout andbatch_report.jsonas diagram batches. Studio Batch tab can run plot manifests. Diagram batches now setbatch_kind: methodology; plot batches setstatistical_plot.batch-reportMD/HTML shows kind when present.Closes #122
Motivation
Authors often need many data figures per paper; looping
plotmanually loses a unified report and output tree. This aligns plots with the existing batch workflow.How to test
pytest tests/test_batch.py tests/test_core/test_plot_data.pypaperbanana plot-batch --manifest examples/plot_batch_manifest.yaml(requires API keys)paperbanana batch-report --batch-dir <batch_dir> --format markdown