Changes for deploying ams workflow#102

Merged

koparasy merged 22 commits intodevelopfrom

features/deploy-bench

Mar 28, 2025

Member

koparasy commented Mar 3, 2025

No description provided.

koparasy requested a review from lpottier

March 3, 2025 18:38

koparasy force-pushed the features/deploy-bench branch 2 times, most recently from 5ddfc10 to 24e7123 Compare

March 21, 2025 19:27

koparasy added 9 commits

March 27, 2025 07:57


          Proper termination of stager when initialized by AMSDeploy

7e95ea1


          Fix prints and print path of config file

c887625


          Proper shutdown of sleep partitions

2dc74bc


          Better assertion message

8d1ecc5


          Add support for async job submission

105ed57


          use flux and ams id, expose ams log dirs

0baeb18


          Detect flux rank id

4ab8b93


          Making AMS dependencies as private

8e579ee


          Adds monitoring of messages in server.

c9a1ecd

Passes correct order of uris to wf_manager.
Sets prefetch to one explicitly.

koparasy force-pushed the features/deploy-bench branch from 4f235a1 to c9a1ecd Compare

March 27, 2025 15:10

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/ams_jobs.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/ams_jobs.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/ams_jobs.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/ams_jobs.py Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/orchestrator.py Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/rmq.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/rmq.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/rmq.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/rmq.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/wf_manager.py Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams_wf/AMSDBStage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams_wf/AMSDeploy.py Outdated Show resolved Hide resolved

koparasy marked this pull request as ready for review

March 27, 2025 16:08

lpottier approved these changes

View reviewed changes

Member

lpottier left a comment

LGTM. Very large PR so we might need further testing even after merge.

src/AMSWorkflow/ams/ams_jobs.py Outdated Show resolved Hide resolved

src/AMSWorkflow/ams/ams_jobs.py Show resolved Hide resolved

src/AMSWorkflow/ams/ams_jobs.py Outdated Show resolved Hide resolved

src/AMSWorkflow/ams/rmq.py Outdated Show resolved Hide resolved

src/AMSWorkflow/ams/rmq.py Outdated Show resolved Hide resolved

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved


          Adding reverting umpire cmake change

ced311f

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy commented

View reviewed changes

src/AMSWorkflow/ams/stage.py Outdated Show resolved Hide resolved

koparasy added 12 commits

March 27, 2025 12:12


          Minor fixes

ef66433


          Fix minor comments

7b19371


          Simple typo

44cf2ff


          Minor

790de24

Nit

79135bb


          Further nits

416db64


          Fix start bug

25257bf


          MInors

37defd7


          Stager now dumps monitor to 'args-<nodename>-<pid>.json' file

3dfda47


          Profiler data

2d0d702


          Fix minors and make wf_manager aware of mdb key

cf95db0


          Pushing changes

597c541

koparasy merged commit 6597cb9 into develop

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet