Introduce explicit initialization of AMS#138
Merged
Conversation
koparasy
reviewed
Apr 14, 2025
koparasy
reviewed
Apr 14, 2025
koparasy
reviewed
Apr 14, 2025
koparasy
approved these changes
Apr 14, 2025
Member
koparasy
left a comment
koparasy
left a comment
There was a problem hiding this comment.
LGTM. Nits and please rebase before we merge.
Member
|
@lpottier In principle AMS does not require MPI. We should leave the user to initialize MPI on their own. |
…alize Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
lpottier
force-pushed
the
features/static-initialization
branch
from
9e63d31 to
dff43f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed static initialization from AMS.
Introduced
AMSInitandAMSFinalizethat users will have to explicitly call to start using AMS.AMSInitalso initializes the Resource Manager.@koparasy One question is, do we want to manage the MPI initialization / Finalize in AMS? It might be better to let users initialize MPI as they want